Skip to content

Fixed the component re-rendering issue which causes the Entity test failure#27355

Merged
harshach merged 4 commits intomainfrom
fix-entity-spec-failure-aut
Apr 14, 2026
Merged

Fixed the component re-rendering issue which causes the Entity test failure#27355
harshach merged 4 commits intomainfrom
fix-entity-spec-failure-aut

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented Apr 14, 2026 •
edited
Loading

Describe your changes:

config.toEntityReference(selectedItems) was called inline in JSX, creating a new array reference on every render. This triggered SelectableList useEffect([selectedItems]) , which reset selectedItemsInternal back from the prop — overwriting the empty Map set by "clear all" before Update was clicked. useMemo stabilizes the reference so the effect only fires when the actual tag data changes.

Fixes

I worked on ... because ...

Screen.Recording.2026-04-14.at.5.18.14.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Rohit0301 Rohit0301 self-assigned this Apr 14, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 14, 2026 11:50
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.99% (59826/93487) 43.71% (31313/71630) 46.81% (9411/20103)

siddhant1
siddhant1 previously approved these changes Apr 14, 2026
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026 •
edited
Loading

🟡 Playwright Results — all passed (32 flaky)

✅ 3624 passed · ❌ 0 failed · 🟡 32 flaky · ⏭️ 84 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 477 0 3 4
🟡 Shard 2 641 0 4 7
🟡 Shard 3 646 0 7 1
🟡 Shard 4 618 0 8 22
✅ Shard 5 612 0 0 42
🟡 Shard 6 630 0 10 8
🟡 32 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › should show all the customize options (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › Pipeline - customization should work (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ChangeSummaryBadge.spec.ts › Automated badge should appear on entity description with Automated source (shard 2, 1 retry)
  • Features/CuratedAssets.spec.ts › Multiple entity types with AND conditions (shard 2, 1 retry)
  • Features/DataProductPersonaCustomization.spec.ts › Data Product - customization should work (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should inherit reviewers from glossary when term is created (shard 2, 1 retry)
  • Features/IncidentManager.spec.ts › Complete Incident lifecycle with table owner (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 2 retries)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Table.spec.ts › Tags term should be consistent for search (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for DashboardDataModel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for MlModel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for ApiEndpoint (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Worksheet (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with tags and glossary terms preserves associations (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Announcement create, edit & delete (shard 4, 1 retry)
  • Features/AutoPilot.spec.ts › Agents created by AutoPilot should be deleted (shard 6, 1 retry)
  • Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
  • Pages/Glossary.spec.ts › Verify Glossary Deny Permission (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab is NOT visible for databaseService in platform lineage (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • ... and 2 more

📦 Download artifacts

How to debug locally 
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@Rohit0301 Rohit0301 dismissed stale reviews from siddhant1 and ShaileshParmar11 via 1d80c0b April 14, 2026 16:33
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 14, 2026 •
edited
Loading

Code Review ✅ Approved

Component lifecycle management has been corrected to prevent unnecessary re-renders, resolving the intermittent Entity test failures. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact 
gitar display:verbose

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 14, 2026

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
1092 New issues
0 Accepted issues

Measures
14 Security Hotspots
0.0% Coverage on New Code
3.8% Duplication on New Code

See analysis details on SonarQube Cloud

@harshach harshach merged commit 4f8e722 into main Apr 14, 2026
52 of 53 checks passed
@harshach harshach deleted the fix-entity-spec-failure-aut branch April 14, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuj-kumary anuj-kumary anuj-kumary approved these changes

@siddhant1 siddhant1 siddhant1 left review comments

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

Assignees

@Rohit0301 Rohit0301

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rohit0301 @siddhant1 @anuj-kumary @ShaileshParmar11 @harshach